Difference between revisions of "Code Review"
From Agility
m |
|||
| Line 2: | Line 2: | ||
Code review is a process designed to: | Code review is a process designed to: | ||
| − | + | * keep code quality | |
| − | + | * catch possible bugs | |
| − | + | * find logical mistakes | |
| − | + | * check for performance issues | |
| − | + | * ensure code is readable and maintainable | |
| − | + | * spread knowledge of the code base throughout the team | |
| − | + | * get new people up to speed with the ways of working | |
| − | + | * expose everyone to different approaches | |
Main goals: | Main goals: | ||
Revision as of 12:56, 6 September 2017
Code review is a process designed to:
- keep code quality
- catch possible bugs
- find logical mistakes
- check for performance issues
- ensure code is readable and maintainable
- spread knowledge of the code base throughout the team
- get new people up to speed with the ways of working
- expose everyone to different approaches
Main goals:
- Code review as a process is not focused on code styling.
- Foster a positive code review culture
- Author had a good intentions while he was writing the code.
- In order to solve any resolution conflicts, second person may be required.
- Contact with author as a replacement of source code annotations.
- Lines of code under review should be less than 200, not exceeding 400
- Inspection rates should under 500 lines of code per hour
- Do not review for more than 60 minutes at a time