Code Review

From Agility
Revision as of 13:03, 6 September 2017 by Sychu (Talk | contribs)

(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to: navigation, search


Code review is a process designed to:

  • improve code quality
  • catch possible bugs
  • find logical mistakes
  • check for performance issues
  • ensure code is readable and maintainable
  • spread knowledge of the code base throughout the team
  • get new people up to speed with the ways of working
  • expose everyone to different approaches

Main goals:

  1. Do not focus on code styling.
  2. Foster a positive code review culture
  3. Assume that author had a good intentions while he was writing the code.
  4. Ask other persons to solve any resolution conflict.
  5. Contact with author as a replacement of source code annotations.
  6. Lines of code under review should be less than 400
  7. Inspection rates should under 500 lines of code per hour
  8. Do not review for more than 60 minutes at a time