Code Review
From Agility
Code review is a process designed to:
- improve code quality
- catch possible bugs
- find logical mistakes
- check for performance issues
- ensure code is readable and maintainable
- spread knowledge of the code base throughout the team
- get new people up to speed with the ways of working
- expose everyone to different approaches
Main goals:
- Do not focus on code styling.
- Foster a positive code review culture
- Assume that author had a good intentions while he was writing the code.
- Ask other persons to solve any resolution conflict.
- Contact with author as a replacement of source code annotations.
- Lines of code under review should be less than 400
- Inspection rates should under 500 lines of code per hour
- Do not review for more than 60 minutes at a time